Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable __FILE__ trim #1401

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Conversation

xufang-lisa
Copy link
Contributor

@xufang-lisa xufang-lisa commented Jun 12, 2024

Description

It's better to use relative path instead of full path while debugging and macro FILE is used.
If the full path is needed, the option "TBB_FILE_TRIM" can help.
for example:
When debugging an application by gdb, if the stack shows the full path like this, it seems inappropriate.

image

It's better to show the relative path like this.
image

Fixes # - issue number(s) if exists

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

Copy link
Contributor

@isaevil isaevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to attach some output examples (from asserts, GDB).

CMakeLists.txt Outdated Show resolved Hide resolved
cmake/compilers/AppleClang.cmake Outdated Show resolved Hide resolved
cmake/README.md Outdated Show resolved Hide resolved
@isaevil isaevil requested a review from aepanchi August 12, 2024 08:24
cmake/README.md Outdated Show resolved Hide resolved
cmake/README.md Outdated Show resolved Hide resolved
@omalyshe omalyshe requested a review from aepanchi September 19, 2024 11:12
@isaevil isaevil merged commit 498a0c7 into uxlfoundation:master Sep 19, 2024
22 of 25 checks passed
kboyarinov pushed a commit that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants