-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable __FILE__ trim #1401
Merged
isaevil
merged 6 commits into
uxlfoundation:master
from
xufang-lisa:xufang/enable_FILE_trim
Sep 19, 2024
Merged
enable __FILE__ trim #1401
isaevil
merged 6 commits into
uxlfoundation:master
from
xufang-lisa:xufang/enable_FILE_trim
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaevil
reviewed
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to attach some output examples (from asserts, GDB).
aepanchi
reviewed
Sep 3, 2024
Co-authored-by: Alexandra <[email protected]>
Co-authored-by: Alexandra <[email protected]>
aepanchi
approved these changes
Sep 19, 2024
kboyarinov
pushed a commit
that referenced
this pull request
Oct 1, 2024
Co-authored-by: Alexandra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's better to use relative path instead of full path while debugging and macro FILE is used.
If the full path is needed, the option "TBB_FILE_TRIM" can help.
for example:
When debugging an application by gdb, if the stack shows the full path like this, it seems inappropriate.
It's better to show the relative path like this.
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@
to send notificationsOther information