Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw() -> noexcept #1405

Merged
merged 1 commit into from
Jul 16, 2024
Merged

throw() -> noexcept #1405

merged 1 commit into from
Jul 16, 2024

Conversation

r-barnes
Copy link
Contributor

Description

Changes the throw() function qualifier to noexcept. throw() is deprecated/removed as of C++17 and noexcept is present from C++11, so this should be an easy switch to improve compatibility with newer standards

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No (unlikely)
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

Copy link
Contributor

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix copyright dates.

@r-barnes
Copy link
Contributor Author

@ldorau - I don't think copyright updates really belong in this PR - those should probably be done for the entire project separately. I'm also not sure what you mean and wish you'd been specific about what you wanted.

Nonetheless, I've taken a guess at what you wanted and updated the PR accordingly.

@ldorau
Copy link
Contributor

ldorau commented Jun 26, 2024

@ldorau - I don't think copyright updates really belong in this PR - those should probably be done for the entire project separately. I'm also not sure what you mean and wish you'd been specific about what you wanted.

@r-barnes Copyright updates do really belong to this PR.
When you submit a pull request, all CI builds should pass. The copyright_check CI job of your PR was failing: https://github.com/oneapi-src/oneTBB/actions/runs/9505732624/job/26254325125.
There are explicitly listed in the log above all copyright dates that should be updated, because you have modified those files.

Nonetheless, I've taken a guess at what you wanted and updated the PR accordingly.

Nonetheless, your guess is correct ;-)

@ldorau
Copy link
Contributor

ldorau commented Jun 26, 2024

@KFilipek @lplewa please review

@r-barnes
Copy link
Contributor Author

@KFilipek @lplewa - just checking in on this

@lplewa lplewa merged commit a74fb75 into uxlfoundation:master Jul 16, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants