Improve robustness of leaked observer warning #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pavelkumbrasev <[email protected]>
Signed-off-by: pavelkumbrasev <[email protected]>
dnmokhov
reviewed
Jun 19, 2024
test/tbb/test_task.cpp
Outdated
Comment on lines
859
to
861
| tbb::parallel_for(0, 100000, [] (int) { | ||
| for (volatile int i = 0; i < 1000; ++i); | ||
| }); |
There was a problem hiding this comment.
volatile warning in C++20
Signed-off-by: pavelkumbrasev <[email protected]>
dnmokhov
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Leaked proxy observers warning could appear during the shutdown process even if there was no memory leak (related structures were destroying concurrently).
This patch improves reliability of the warning by removing dependency on global variable destructor and moving warning to the
release_resources(all of the proxies should be destroyed 100%).Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information