Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor set of soft_limit to fix a bug #1418

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Refactor set of soft_limit to fix a bug #1418

merged 4 commits into from
Jun 25, 2024

Conversation

pavelkumbrasev
Copy link
Contributor

Description

In the current implementation zero soft_limit would be ignored because of errors in mandatory concurrency checks.
This patch refactors the function allows zero soft_limit to be set.

Fixes # - issue number(s) if exists
#1417

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

@pavelkumbrasev pavelkumbrasev self-assigned this Jun 25, 2024
@pavelkumbrasev pavelkumbrasev linked an issue Jun 25, 2024 that may be closed by this pull request
tbb::global_control does not stop spinning threads #1417
Closed
isaevil
isaevil reviewed Jun 25, 2024
View reviewed changes
Copy link
Contributor

@isaevil isaevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug fix looks good. Left comments about the test.

test/tbb/test_global_control.cpp Outdated Show resolved Hide resolved
test/tbb/test_global_control.cpp Outdated Show resolved Hide resolved
test/tbb/test_global_control.cpp Outdated Show resolved Hide resolved
test/tbb/test_global_control.cpp Outdated Show resolved Hide resolved
pavelkumbrasev and others added 2 commits June 25, 2024 13:37
isaevil
isaevil approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@isaevil isaevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pavelkumbrasev pavelkumbrasev merged commit 718aaf8 into master Jun 25, 2024
16 of 22 checks passed
@pavelkumbrasev pavelkumbrasev deleted the dev/pavelkumbrasev/fix_zero_soft_limit branch June 25, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaevil isaevil isaevil approved these changes

@dnmokhov dnmokhov Awaiting requested review from dnmokhov

@sarathnandu sarathnandu Awaiting requested review from sarathnandu

Assignees

@pavelkumbrasev pavelkumbrasev

Labels
bug fix bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tbb::global_control does not stop spinning threads
2 participants
@pavelkumbrasev @isaevil