Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension of Nd range #1449

Merged
merged 28 commits into from
Nov 7, 2024
Merged

Conversation

tobiasweinzierl80
Copy link
Contributor

@tobiasweinzierl80 tobiasweinzierl80 commented Jul 13, 2024

Description

We found that it is very useful for our code if we can construct the range from plain integers. For this, the underlying datatype storing the ranges has to be changed to vector. This should have no negative impact on the performance. However, it makes using the class easier.

The class could do with more assertions and more docu.

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • [X ] new feature - change that adds functionality
  • [X ] tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • [ X] added - required for new features and some bug fixes
  • not needed

Documentation

Breaks backward compatibility

  • Yes
  • [ X] No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

@pavelkumbrasev pavelkumbrasev requested a review from vossmjp July 15, 2024 06:56
include/oneapi/tbb/blocked_rangeNd.h Outdated Show resolved Hide resolved
include/oneapi/tbb/blocked_rangeNd.h Outdated Show resolved Hide resolved
@sasalla23
Copy link
Contributor

I have implemented the changes discussed in the spec as well as the changes concerning std::array. The initialization of the array in the constructor with parameter size[N] as described by @akukanov works from what I tested. As I said in the spec, I have removed the constructor that uses begin[N] and end[N] and renamed ndims to dim_count. Let me know if this poses a problem or if there is anything missing.

include/oneapi/tbb/blocked_rangeNd.h Outdated Show resolved Hide resolved
include/oneapi/tbb/blocked_rangeNd.h Outdated Show resolved Hide resolved
Copy link
Contributor

@pavelkumbrasev pavelkumbrasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that LGTM

include/oneapi/tbb/blocked_rangeNd.h Show resolved Hide resolved
Copy link
Contributor

@pavelkumbrasev pavelkumbrasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pavelkumbrasev
pavelkumbrasev previously approved these changes Oct 30, 2024
include/oneapi/tbb.h Outdated Show resolved Hide resolved
test/tbb/test_blocked_range.cpp Outdated Show resolved Hide resolved
Co-authored-by: Konstantin Boyarinov <[email protected]>
pavelkumbrasev
pavelkumbrasev previously approved these changes Nov 5, 2024
kboyarinov
kboyarinov previously approved these changes Nov 6, 2024
Copy link
Contributor

@kboyarinov kboyarinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: pavelkumbrasev <[email protected]>
@pavelkumbrasev pavelkumbrasev dismissed stale reviews from kboyarinov and themself via fa0db8e November 7, 2024 08:45
@pavelkumbrasev pavelkumbrasev merged commit d1d43ad into uxlfoundation:master Nov 7, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants