Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flow_graph tests build when compiling with GCC 13.3 #1543

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

isaevil
Copy link
Contributor

@isaevil isaevil commented Oct 31, 2024

Description

Fix the following compilation errors:

tbb/include/oneapi/tbb/flow_graph.h:308:13: error: no matching function for call to 'wait::wait(tbb::detail::d1::wait_context&, tbb::detail::d1::task_group_context&)'
  308 |             wait(msg_wait_vertex.get_context(), *graph_reference().my_context);
      |       
tbb/include/oneapi/tbb/detail/_flow_graph_impl.h:350:71: error: no matching function for call to 'wait::wait(tbb::detail::d1::wait_context&, tbb::detail::d1::task_group_context&)'
  350 |                 wait(my_wait_context_vertex.get_context(), *my_context);
      |  

Fixes #1540

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

Copy link
Contributor

@pavelkumbrasev pavelkumbrasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pavelkumbrasev pavelkumbrasev merged commit 9c9ace2 into master Nov 1, 2024
27 checks passed
@pavelkumbrasev pavelkumbrasev deleted the dev/isaevil/fix-gcc13.3-compilation branch November 1, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux build in conda can't find correct wait function
2 participants