RFC to change dependency loading process #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelkumbrasev
previously approved these changes
Nov 26, 2024
|
@egfefey please take a look as well. |
akukanov
reviewed
Nov 26, 2024
rfcs/proposed/loading-dependencies/loading-dependencies-by-module-name.org
Outdated
Show resolved
Hide resolved
egfefey
reviewed
Nov 26, 2024
akukanov
previously approved these changes
Nov 26, 2024
vossmjp
previously approved these changes
Dec 6, 2024
rfcs/proposed/loading-dependencies/loading-dependencies-by-module-name.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/loading-dependencies/loading-dependencies-by-module-name.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/loading-dependencies/loading-dependencies-by-module-name.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/loading-dependencies/loading-dependencies-by-module-name.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/loading-dependencies/loading-dependencies-by-module-name.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/loading-dependencies/loading-dependencies-by-module-name.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/loading-dependencies/loading-dependencies-by-module-name.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/loading-dependencies/loading-dependencies-by-module-name.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/loading-dependencies/loading-dependencies-by-module-name.org
Outdated
Show resolved
Hide resolved
rfcs/proposed/loading-dependencies/loading-dependencies-by-module-name.org
Outdated
Show resolved
Hide resolved
aleksei-fedotov
dismissed stale reviews from vossmjp and akukanov
via
ec09e71
Signed-off-by: Fedotov, Aleksei <[email protected]>
Signed-off-by: Fedotov, Aleksei <[email protected]>
Co-authored-by: Mike Voss <[email protected]>
aleksei-fedotov
force-pushed
the
dev/aleksei-fedotov/rfc-run-time-dependency-loading
branch
from
b3c5e90 to
8cba89f
Compare
|
Applying review remarks have dismissed all the approvals. Due to impossibility to merge the changes that were actually approved, I have to ask reviewers to put at least one additional formal approval one more time. |
akukanov
approved these changes
Dec 10, 2024
aleksei-fedotov
deleted the
dev/aleksei-fedotov/rfc-run-time-dependency-loading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add RFC about loading dependencies by module name only.
Type of change
Tests
Documentation
Breaks backward compatibility