[UnitMux] Fix test tear down #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the allocator info is not restored to a valid state before the end of the test, the device is not destroyed properly as `muxDestroyDevice()` checks for a valid allocator info before doing anything. If the device object holds any exclusive resources, this makes all following tests fail.
coldav
approved these changes
Oct 2, 2023
coldav
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This commit restores the allocator info to a valid state before the end of the
InvalidAllocatortest.Reason for change
If the allocator info is not restored to a valid state before the end of the test, the device is not destroyed properly as
muxDestroyDevice()checks for a valid allocator info before doing anything. If the device object holds any exclusive resources, this makes all following tests fail.