Release any queues left when atexit is called. #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldav
force-pushed
the
colin/workaround_queue_closedown_issue
branch
from
375330d to
4b6a5a5
Compare
hvdijk
reviewed
Oct 4, 2023
coldav
force-pushed
the
colin/workaround_queue_closedown_issue
branch
2 times, most recently
from
2ca5f98 to
2a81a4c
Compare
hvdijk
approved these changes
Oct 5, 2023
This is due to an issue with dpc++ where it can leave temporary queues unreleased. This can then have the effect on the closing down of the device. This is resolved by registering and deregistering the queues on creation and deletion and then releasing any queues which still have an external reference when `atexit` is called. This required an additional device mutex to avoid threading issues. This should be reviewed when intel/llvm#11156 is fixed.
coldav
force-pushed
the
colin/workaround_queue_closedown_issue
branch
from
2a81a4c to
720cab7
Compare
hvdijk
reviewed
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Release any queues left when atexit is called.
Reason for change
This is due to an issue with dpc++ where it can leave temporary queues unreleased. This can then have the effect on the closing down of the device.
Description of change
This is resolved by registering and deregistering the queues on creation and deletion and then releasing any queues which still have an external reference when
atexitis called.This should be reviewed when intel/llvm#11156 is fixed.