Fix various small issues found in the tutorial docs #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a number of small issues (typos, inconsistencies, etc.) that I found while going through the two tutorials (HAL and ComputeMux).
Reason for change
Improve doc quality and make it easier to follow.
Description of change
Maybe the only noteworthy change is the fix to the pseudo code of the rewrite pass. As I implemented a kernel interface adapter in C instead of using an LLVM pass, the wrong pseudo code tripped me up initially. I then peeked at what the reference rewrite pass was doing and found the mismatch.