Fix build with MSVC, fix VectorAddition test. #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldav
approved these changes
Oct 8, 2024
* MSVC wants max to be captured if it has automatic storage. It should not, but the MSVC option to behave in a standards-conforming manner is only available in newer versions than what we aim to support, so work around this by changing the storage to static. * VectorAddition calls vkMapMemory which takes a pointer to a void* output parameter, then copies the result to a int32_t* variable for easier access. In commit ea1a63d, I missed one copy.
hvdijk
changed the title
coldav
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix build with MSVC, fix VectorAddition test.
Reason for change
Description of change
Anything else we should know?
If there's any other relevant information we should know that may help us in
understanding and verifying your patch, please include it here.
Checklist