Add first windows pull-request job #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldav
reviewed
Oct 17, 2024
alan-forbes-cp
changed the title
alan-forbes-cp
force-pushed
the
alan/OR-578_priority_windows_pr_job
branch
from
7b80196 to
ceda4f3
Compare
alan-forbes-cp
changed the title
coldav
reviewed
Oct 18, 2024
coldav
reviewed
Oct 18, 2024
coldav
reviewed
Oct 18, 2024
coldav
reviewed
Oct 18, 2024
coldav
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a first windows PR job: mr-windows-msvc-x86_64-llvm-latest-cl3-0-offline
This required some refactoring and consolidation to handle both ubuntu & windows.
Reason for change
This job was identified as one of the "priority" jobs - collectively giving a reasonable coverage of PR job types and (hopefully) simplifying the addition of others.
Description of change
In addition to the new job itself, the change consolidates windows/ubuntu as part of the build setup action and bash/powershell as part of the build command action.
Test builds for all currently supported PR jobs have been run.
Anything else we should know?