Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: increase tests timeout to 170 #2075

Merged
merged 1 commit into from
Oct 2, 2024
Merged

MAINT: increase tests timeout to 170 #2075

merged 1 commit into from
Oct 2, 2024

Conversation

homksei
Copy link
Contributor

@homksei homksei commented Sep 30, 2024 •
edited
Loading

Description

In this PR, the timeout for tests was increased due to longer execution times after transitioning to oneMKL.

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.

@homksei homksei added the testing Tests for sklearnex/daal4py/onedal4py & patching sklearn label Sep 30, 2024
@homksei homksei requested review from Vika-F and samir-nasibli and removed request for samir-nasibli and Alexsandruss September 30, 2024 17:39
@samir-nasibli samir-nasibli changed the title MNT increase tests timeout to 170 MAINT: increase tests timeout to 170 Sep 30, 2024
@samir-nasibli
Copy link
Contributor

@homksei @Alexandr-Solovev are we going to integrate this?

@homksei homksei merged commit 2c73bb8 into uxlfoundation:main Oct 2, 2024
11 of 35 checks passed
@ahuber21
Copy link
Contributor

Was it really necessary to globally increase the timeout? Are all tests now running longer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samir-nasibli samir-nasibli samir-nasibli approved these changes

@Vika-F Vika-F Awaiting requested review from Vika-F

@Alexsandruss Alexsandruss Awaiting requested review from Alexsandruss Alexsandruss is a code owner

Assignees
No one assigned
Labels
testing Tests for sklearnex/daal4py/onedal4py & patching sklearn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@homksei @samir-nasibli @ahuber21