-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] changes for GitHub actions PR CI for matching oneDAL Nightly-build #2076
Conversation
Still a problem with kneighbors and stability, this probably will need to be deselected and a ticket made for investigation. |
Still to be done: ticket for investigations on kneighbors stability issues. Ideally the CI should be re-run 8-10x to make sure I caught all the intermittent failures. I need to add the additional sparsity deselections to the sparsity investigation ticket, and is exhibited both in Intel and non-Intel hardware. |
/intelci: run |
/intelci: run |
/intelci: run |
if ( | ||
not _IS_INTEL | ||
and ("Neighbors" in estimator or "LocalOutlierFactor" in estimator) | ||
and method in ["score", "predict", "kneighbors", "kneighbors_graph"] | ||
): | ||
if daal_check_version((2025, "P", 200)): | ||
pytest.fail("Re-verify failure of algorithms in 2025.2 oneDAL") | ||
pytest.skip(f"{estimator} shows instability on Non-Intel hardware") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose to make a common function for checking and disabling as the nature of these crashes is the same.
Also less code duplication
def _skip_neighbors(estimator, method):
if (
not _IS_INTEL
and ("Neighbors" in estimator or "LocalOutlierFactor" in estimator)
and method in ["score", "predict", "kneighbors", "kneighbors_graph"]
):
if daal_check_version((2025, "P", 200)):
pytest.fail("Re-verify failure of algorithms in 2025.2 oneDAL")
pytest.skip(f"{estimator} shows instability on Non-Intel hardware")
if ( | |
not _IS_INTEL | |
and ("Neighbors" in estimator or "LocalOutlierFactor" in estimator) | |
and method in ["score", "predict", "kneighbors", "kneighbors_graph"] | |
): | |
if daal_check_version((2025, "P", 200)): | |
pytest.fail("Re-verify failure of algorithms in 2025.2 oneDAL") | |
pytest.skip(f"{estimator} shows instability on Non-Intel hardware") | |
_skip_neighbors(estimator, method) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't have permissions to Ian's branch. Going to merge this and add refactoring my suggestion as a follow up. Don't want to block green CI enabling
Description
Fixes to return CI to green as Nightly-build was changed in uxlfoundation/oneDAL#2865 and uxlfoundation/oneDAL#2920
No operational changes made, thus benchmarking unnecessary.
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance