Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: new tests added for tsne to expand test coverage #2229
base: main
Are you sure you want to change the base?
feature: new tests added for tsne to expand test coverage #2229
Changes from all commits
c686edd
f3f5223
10da764
2f3e9fa
739a90c
822e614
c6bf0bd
5d2da20
e95f5a3
44f3c14
cba1ce9
ba7658e
dc04722
9791ea4
11f5edc
8c1dc28
1fbc7f0
a57cd08
28f9815
0753153
032cf6b
dbfea49
153c58c
4ddb1a8
5340cd2
9a9c547
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion the only thing missing from test scope is an exact result check, which I agree would be unrealistic for all tests, but since the import test is small would it be possible to add a specific embedding value check here after transform? Something like we have for pca here: https://github.com/uxlfoundation/scikit-learn-intelex/blob/main/sklearnex/decomposition/tests/test_pca.py#L35-L41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Ethan,
I tried to have an exact value test but it is having different numbers across the tests and causing CI failed. I tried to add a few extra parameters (init, number of iterations) to keep it more stable, but it still generate very different numbers for every test. I also read the source code. I think the reason pca can have kind of test because it is using deterministic computations and I can compute exact numbers step by step. But tsne's algorithm is non linear and involve gradient descent and local proximations, which all give variabilities. I removed that part of test for now but not sure if this is the correct understanding, let me know your thoughts!
Best,
Yue