Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] fix to_table for a non-array input when a low-precision queue is used #2271

Merged
merged 16 commits into from
Jan 27, 2025

Conversation

icfaust
Copy link
Contributor

@icfaust icfaust commented Jan 24, 2025

Description

This fixes an issue discovered in #2253 where it would try to query the dtype of a None object. First must be checked if it is an array, then the necessary dtype verification should occur. This error only arises for SYCL GPUs which do not have the fp64_aspect.


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
onedal/datatypes/data_conversion.cpp 20.00% 0 Missing and 4 partials ⚠️
Flag Coverage Δ
azure 77.96% <100.00%> (-0.01%) ⬇️
github 71.03% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
onedal/basic_statistics/basic_statistics.py 100.00% <100.00%> (ø)
onedal/datatypes/data_conversion.cpp 50.24% <20.00%> (+0.24%) ⬆️

... and 2 files with indirect coverage changes

@icfaust
Copy link
Contributor Author

icfaust commented Jan 24, 2025

/intelci: run

@icfaust icfaust marked this pull request as ready for review January 25, 2025 01:14
@icfaust
Copy link
Contributor Author

icfaust commented Jan 27, 2025

/intelci: run

@icfaust icfaust merged commit e4a3750 into uxlfoundation:main Jan 27, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants