Fixes and Swift => 4.0 upgrade #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, it should not assume that the Pen tool is button index 1. It should find it by type or assert otherwise.
That is, when disappearing from the view, the settor of that closure could infer from the passed PDFAnnotationController whether there are things to save, and if so, decide where/what to do or just ignore etc. Default behaviour is as before, just assigns the annotations out of the annotationController to the PDFDocument itself, then call save() on that document to archiveRootObject.
In PDFAnnotationController, and PDFAnnotationStore
Default does what it always does, calls dismiss(animated: true, completion: nil)
start up a new annotation after undoing one
better pen width and better undo functionality
- undo should still be enabled if you start an empty annotation while there are annotations in the store
fix it better
…ry leak with delegates
|
Very interesting! Thanks for collecting these @diegostamigni - hope to be able to try out your branch this week or the following. When I do, I'll let you know if there are any weird effects I see. |
|
Thanks @scottcc, just bear in mind that I've changed the Travis link in the README.md and the git repo URL in the Podspec file. |
|
No problem - for stuff we're changing with any regularity at all, we typically point the Podfile reference to a commit SHA instead rather than going the full install-through-cocoapods (not to mention I couldn't push to the official cocoapods repo as I'm not the owner) |
…nailViewController collection view spacing added between lines
…t annotation file for a specific document)
Fixes from Withinapp and Example project update
Merge in diegostamigni master branch
Feature/annotations
Fix on retained self
Merge in choice fields feature
- bump version to 0.8.5
- fix warnings from Travis CI
adds choice fields functionality
- fix sizing of signature annotation when rendering to flat pdf
- Fixes orientation of signature annotation on final exported pdf
Correct sizing and orientation of signature field/annotation on exported flat pdf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've collected a bunch of fixes from different forks, upgraded the code to swift 4.0 and personally fixed some potential memory leaks with non-weak delegates.