Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor SCC Registration flow #7773

Merged

Conversation

rjpmestre
Copy link
Contributor

@rjpmestre rjpmestre commented Oct 26, 2023

What does this PR change?

This pr refactors SCC system register applying a chain of responsibility pattern.
As this flow does not have a dedicated documentation, having the steps decoupling increases readability and testability.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • Unit tests were added

  • DONE

Links

Fixes #

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@rjpmestre rjpmestre requested a review from a team as a code owner October 26, 2023 10:09
@rjpmestre rjpmestre requested review from rjmateus and removed request for a team October 26, 2023 10:09
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/7773/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/7773/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@github-actions
Copy link
Contributor

Suggested tests to cover this Pull Request

@rjmateus rjmateus requested review from lucidd and mcalmer October 31, 2023 12:08
Copy link
Member

@rjmateus rjmateus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please wait for Kevin and MC review

Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small nitpicks and checkstyle is failing. I think javadoc is missing.

@@ -0,0 +1,80 @@
/*
* Copyright (c) 2021 SUSE LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have 2023 :-)

@rjpmestre rjpmestre closed this Nov 15, 2023
@rjpmestre rjpmestre force-pushed the scc_registration_flow_refactor branch from 9df9b51 to 46ea915 Compare November 15, 2023 14:09
@rjpmestre rjpmestre reopened this Nov 15, 2023
@rjpmestre rjpmestre requested a review from mcalmer November 16, 2023 09:35
@rjpmestre rjpmestre force-pushed the scc_registration_flow_refactor branch from f6c5476 to 04daab9 Compare November 16, 2023 12:53
@rjpmestre rjpmestre force-pushed the scc_registration_flow_refactor branch from 04daab9 to 647aa80 Compare November 16, 2023 12:58
@rjpmestre rjpmestre force-pushed the scc_registration_flow_refactor branch from 405281e to ce82007 Compare November 17, 2023 07:45
Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Check what you want to do about the SonarCloud error.

@rjpmestre rjpmestre merged commit 7d0c4af into uyuni-project:master Nov 17, 2023
7 of 15 checks passed
@rjpmestre rjpmestre deleted the scc_registration_flow_refactor branch June 20, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants