Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update enabled software channels number #7785

Merged

Conversation

maximenoel8
Copy link
Contributor

@maximenoel8 maximenoel8 commented Oct 27, 2023

What does this PR change?

Update enabled software channel. We need a description of the expected channels in the future.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@maximenoel8 maximenoel8 requested a review from a team as a code owner October 27, 2023 01:16
@github-actions
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/7785/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/7785/checks.
See the troubleshooting guide if you need any help.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@maximenoel8 maximenoel8 changed the title Update enabled software channel number Update enabled software channels number Oct 27, 2023
Copy link
Member

@nodeg nodeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you. We have a card in our inbox for refactoring this and always have the correct channels selected. See https://github.com/SUSE/spacewalk/issues/22701

Copy link
Member

@srbarrios srbarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix the red indeed.
But that's what we really want?

If a user runs this test manually, it will see one less channel subscribed on the WebUI, therefore this value is missleading.

In my opinion, instead (or in addition) of running a zypper command to retrieve the enabled repos, we want to retrieve from the WebUI or the API the amount of subscribed channels (or even better, check one by one that all the channels we expect are subscribed).

So, approving, but please add a TODO comment with the card for the refactor so we keep that in mind im the future.

@deneb-alpha
Copy link
Contributor

checked with @nodeg and @srbarrios and decided to merge

@deneb-alpha deneb-alpha merged commit dc1f893 into uyuni-project:master Oct 27, 2023
6 of 9 checks passed
@srbarrios
Copy link
Member

srbarrios commented Oct 27, 2023

Please @maximenoel8 , on this PR changes it was not considered my comment:

So, approving, but please add a TODO comment with the [card](https://github.com/SUSE/spacewalk/issues/22908) for the refactor so we keep that in mind in the future.

Could you add the TODO to be sure we will take care about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants