-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update enabled software channels number #7785
Update enabled software channels number #7785
Conversation
👋 Hello! Thanks for contributing to our project. Happy hacking! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you. We have a card in our inbox for refactoring this and always have the correct channels selected. See https://github.com/SUSE/spacewalk/issues/22701
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix the red indeed.
But that's what we really want?
If a user runs this test manually, it will see one less channel subscribed on the WebUI, therefore this value is missleading.
In my opinion, instead (or in addition) of running a zypper command to retrieve the enabled repos, we want to retrieve from the WebUI or the API the amount of subscribed channels (or even better, check one by one that all the channels we expect are subscribed).
So, approving, but please add a TODO comment with the card for the refactor so we keep that in mind im the future.
checked with @nodeg and @srbarrios and decided to merge |
Please @maximenoel8 , on this PR changes it was not considered my comment:
Could you add the TODO to be sure we will take care about this? |
What does this PR change?
Update enabled software channel. We need a description of the expected channels in the future.
GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
No tests: already covered
DONE
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: