Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server image cleanup #9577

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Dec 16, 2024

What does this PR change?

Reduce the number of unneeded layers by grouping the RUN commands and all the files in an ADD from a tarball.
Also remove depending on packages added in the container by the CI to allow removing the repos from the image.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests: cucumber tests changed

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/26016
Port(s): # add downstream PR(s), if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@cbosdo cbosdo requested review from a team as code owners December 16, 2024 10:42
@cbosdo cbosdo requested review from meaksh and removed request for a team December 16, 2024 10:42
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9577/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9577/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@cbosdo
Copy link
Contributor Author

cbosdo commented Jan 21, 2025

Sumaform PR matching this cleanup: uyuni-project/sumaform#1772

@cbosdo cbosdo force-pushed the server-image-cleanup branch from df850c2 to ed21dd7 Compare January 21, 2025 11:10
@cbosdo
Copy link
Contributor Author

cbosdo commented Jan 21, 2025

Addressing part of https://github.com/SUSE/spacewalk/issues/23617

else
server.run('ipmi_sim -n < /dev/null > /dev/null &', verbose: true, check_errors: true)
end
server.run_local('podman run -d --rm --network uyuni -p [::]:623:623/udp -p [::]:9002:9002 --name fakeipmi ghcr.io/uyuni-project/uyuni/ci-fakeipmi:master', verbose: true, check_errors: true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for now.
Maybe in the future we want to have the url of this container image as a env. variables passed through sumaform.

srbarrios
srbarrios previously approved these changes Jan 21, 2025
Copy link
Member

@srbarrios srbarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. All test code looks good to me, thank you very much to take this effort.

@cbosdo cbosdo force-pushed the server-image-cleanup branch 3 times, most recently from 1485f50 to 5864623 Compare January 21, 2025 17:06
@cbosdo cbosdo force-pushed the server-image-cleanup branch from 5864623 to 46b71b3 Compare January 22, 2025 11:11
OBS cannot handle folders as sources, compress a folder named root in
the container folder into a root.tar.gz before pushing to OBS.
In order to remove the repositories from the container image the
testsuite needs to stop relying on sumaform to add any package like
expect.
The CI should never rely on packages being installed in the container.
The OpenIPMI package needed for the simulation is now in a container.
@cbosdo cbosdo force-pushed the server-image-cleanup branch from 46b71b3 to 9094459 Compare January 22, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants