You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, components like vaadin-date-picker-overlay do not respect custom dir set on the host element.
The only case that supports this is vaadin-combo-box-overlay that uses custom logic for this:
Note: prior to #7677 the dir was set based on getComputedStyle(this).direction. This logic is now removed to enable using globally set dir attribute value on overlay based components. But we probably should also check host dir.
Expected outcome
Expected the dir='rtl' to be set on the overlay when provided on the host element by components such as:
vaadin-date-picker
vaadni-select
vaadin-menu-bar
Note: the vaadin-time-picker is a special case since it enforces dir='ltr' on the overlay by design.
Description
Currently, components like
vaadin-date-picker-overlay
do not respect customdir
set on the host element.The only case that supports this is
vaadin-combo-box-overlay
that uses custom logic for this:web-components/packages/combo-box/src/vaadin-combo-box-overlay-mixin.js
Lines 28 to 33 in 451c328
Note: prior to #7677 the
dir
was set based ongetComputedStyle(this).direction
. This logic is now removed to enable using globally setdir
attribute value on overlay based components. But we probably should also check hostdir
.Expected outcome
Expected the
dir='rtl'
to be set on the overlay when provided on the host element by components such as:vaadin-date-picker
vaadni-select
vaadin-menu-bar
Note: the
vaadin-time-picker
is a special case since it enforcesdir='ltr'
on the overlay by design.Minimal reproducible example
Steps to reproduce
dir
in dev toolsEnvironment
Vaadin version(s): 24.x, also earlier versions
Browsers
Issue is not browser related
The text was updated successfully, but these errors were encountered: