fix!: do not override dir attribute on the overlay to rely on DirMixin #7677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like Material theme of the date-picker needs updates, I will look into it. |
web-padawan
changed the title
|
vursen
approved these changes
Aug 21, 2024
Good point. We have some logic for this in |
|
This ticket/PR has been released with Vaadin 24.5.0.beta2 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7676
This removes logic for setting
dirbased oncomputedStyle.direction- originally this line was added in #2567 when updatingvaadin-date-pickerto usePositionMixin(previously, date-picker was settingdirto theinputElementdirection which was introduced long ago in vaadin/vaadin-date-picker#584).Setting
dirthis way is problematic since it overridesdirattribute propagation from the<html>element which is performed byDirMixin. As a result, oncediris set toltrit can't be changed tortlupon overlay re-opening. In fact, the current tests just don't verify the value of thedirattribute set on the overlay.This PR removes the line so that we could rely on the
DirMixininstead, and updates RTL tests accordingly so that we don't close and reopen overlay in these tests and rely ondirattribute being updated.Note, manual
updatePosition()is used in the tests to align with other tests below and because the target is absolutely positioned, so it's not moved whendirupdated to RTL (which would generally be the case in the real world apps).Type of change
Note
Marked as behavior altering fix since this change involves removal of
dir='ltr'set by default from some overlay based components (see snapshots) and in theory some custom styles might rely on it, as did Material theme in 1 place.