fix: wait for editor focusout on Tab to get updated value #7822
+299
−158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
commented
Sep 19, 2024
| @@ -1,3 +1,4 @@ | |||
| import './not-animated-styles.js'; | |||
There was a problem hiding this comment.
Since we have "select column" tests in this suite, I though it would be good to disable select animation.
web-padawan
commented
Sep 19, 2024
Comment on lines
+309
to
+312
| // Ignore focusout from internal tab event | ||
| if (this.__cancelCellSwitch) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Previously the flag was only checked on keydown in _switchEditCell method. However, now when we wait for the native focusout it is necessary to also check it here, otherwise the debouncer will stop editing.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #7796
Fixes #7108
Updated the logic on Tab to not call
event.preventDefault()and move focus synchronously as this doesn't handle the case when custom editor component is updating its value on blur (this is how e.g.vaadin-date-pickerworks).Instead, we now let the browser handle the Tab key press so that the
focusoutevent is caused by that, and wait for it to be fired (unless the event is fromvaadin-select-overlayin which case we still handle it manually).Note, the focus is still moved to the next cell by the logic in
_switchEditCell()after thefocusoutso the keyboard navigation works as expected. I had to update tests fromtab()helper to usesendKeys()to verify this fix.Also added the integration test for custom editor using
vaadin-date-picker(could reuse that later to also cover the second part of the issue, which is about value not updated on overlay closing - that would be a separate PR).UPD: also added the integration test using
vaadin-combo-boxwhich was also affected by the issue with Tab.Type of change