Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve virtual-list a11y #8328

Merged
merged 1 commit into from
Dec 12, 2024
Merged

feat: improve virtual-list a11y #8328

merged 1 commit into from
Dec 12, 2024

Conversation

tomivirkki
Copy link
Member

Description

Extracted from #8318
Part of vaadin/platform#6838

Address the following a11y-related topics from the AC:

  • When selection is disabled, VirtualList has ARIA role="list" and item wrappers have role="listitem"
  • VirtualList needs an aria-label(ledby) API in order to provide an accessible name
    • Added as itemAccessibleNameGenerator

This PR also adds aria-setsize and aria-posinset attributes to the elements.

Type of change

Feature

@tomivirkki tomivirkki requested a review from vursen December 11, 2024 14:58
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tomivirkki tomivirkki mentioned this pull request Dec 11, 2024
Open
@tomivirkki tomivirkki merged commit 4c0d03b into main Dec 12, 2024
9 checks passed
@tomivirkki tomivirkki deleted the feat/virtual-list-a11y branch December 12, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vursen vursen vursen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomivirkki @vursen