-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to check for holidays within an interval of time #1825
Comments
Hi @dsoprea!
I don't recall PRs welcome. Or you may get lucky if @KJhellico or me will be able to find some time this month. Perhaps, by extending Thanks for the idea! |
If you could suggest a straightforward approach then I could do it. If it requires research or rewiring then that'd be best left to the maintainers. |
Yeah, it's up to you. I believe any PR would require some research of the existing code base, project architecture and generally used approaches. I suggest looking at some of the most recent PRs (perhaps, changes related to Just make sure to let us know if you decide to work on this so no work would be done twice. Thank you @dsoprea! |
I'm looking for something similar - but would like to revert the logic. How about adding a function to get the "next" holiday. Getting the amount of days is easy with existing datetime functions. e.g. a function returning the date. `
I would be willing to create a MR if you agree with the approach, Thanks P.S. Another idea for an extention would be to get a function to get the "number of working days" (similar to get_nth_working_day) from now to some other date - e.g. the next holiday returned via getNextHoliday(). |
Sounds good, I'd only recommend it to return a tuple
Maybe also add a @KJhellico @PPsyrius any suggestions? |
OK guys, I will then give it a try. And yes - returning a tuple is a good idea. Thanks. |
a new function get_next_holiday is added to retrieve the date of the next known holiday. Also the name of the holiday is returned. It is possible to search forward and backward in time. This should solve vacanza#1825 Signed-off-by: Schrotti <[email protected]>
a new function get_next_holiday is added to retrieve the date of the next known holiday. Also the name of the holiday is returned. It is possible to search forward and backward in time. This should solve vacanza#1825 Signed-off-by: Schrotti <[email protected]>
a new function get_next_holiday is added to retrieve the date of the next known holiday. Also the name of the holiday is returned. It is possible to search forward and backward in time. This should solve vacanza#1825 Signed-off-by: Schrotti <[email protected]>
a new function get_next_holiday is added to retrieve the date of the next known holiday. Also the name of the holiday is returned. It is possible to search forward and backward in time. This should solve vacanza#1825 Signed-off-by: Schrotti <[email protected]>
a new function get_next_holiday is added to retrieve the date of the next known holiday. Also the name of the holiday is returned. It is possible to search forward and backward in time. This should solve vacanza#1825 Signed-off-by: Schrotti <[email protected]>
a new function get_next_holiday is added to retrieve the date of the next known holiday. Also the name of the holiday is returned. It is possible to search forward and backward in time. This should solve vacanza#1825 Signed-off-by: Schrotti <[email protected]>
I'd like to be able to determine if there are any holidays in the near future, expressed as a
timedelta
. More generally, maybe just between two dates.Pseudocode:
It's not clear if holidays supports just checking certain dates in order for developers to be able to implement this ourselves. It seems sort of there, except that I wonder what happens due to the year handling if the next sixty days includes both December and January. Based on the design of
_add_holiday()
, they're seemingly stored in a year-specific fashion:https://github.com/vacanza/python-holidays/blob/fde28db1d17e05e0853585936b8b8f85e9e38d34/holidays/holiday_base.py#L737
Suggestions?
The text was updated successfully, but these errors were encountered: