add function to get the next holiday #2211
Open
+135
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rosi2143
requested review from
arkid15r,
KJhellico and
PPsyrius
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2211 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 196 196
Lines 11842 11856 +14
Branches 1708 1712 +4
=========================================
+ Hits 11842 11856 +14 ☔ View full report in Codecov by Sentry. |
|
@Rosi2143, it's good start! But some checks are required. Try to run this: from holidays.countries.ukraine import UA
ua = UA()
ua.get_next_holiday("1991-01-01", True)
ua.get_next_holiday("2022-03-08") |
|
@KJhellico: Thanks - I didn't know that there is a start/end-date for a calender. But I guess for some countries it makes sense. Added the checks and the documentation with the latest version. |
Rosi2143
force-pushed
the
add_get_next_holiday
branch
from
053f942 to
562bfa1
Compare
Rosi2143
force-pushed
the
add_get_next_holiday
branch
from
562bfa1 to
c91e03e
Compare
Rosi2143
force-pushed
the
add_get_next_holiday
branch
from
b353dde to
a5554fb
Compare
KJhellico
reviewed
Jan 10, 2025
Rosi2143
force-pushed
the
add_get_next_holiday
branch
from
a5554fb to
c9cd832
Compare
arkid15r
reviewed
Jan 10, 2025
a new function get_next_holiday is added to retrieve the date of the next known holiday. Also the name of the holiday is returned. It is possible to search forward and backward in time. This should solve vacanza#1825 Signed-off-by: Schrotti <[email protected]>
Rosi2143
force-pushed
the
add_get_next_holiday
branch
from
c9cd832 to
adf4653
Compare
|
Since the holidays in the holidays entity object are not always placed in chronological order, it's necessary to sort them before searching: >>> from holidays.countries.united_states import US
>>> h = US(years=2024)
>>> h.get_next_holiday("2024-02-01")
(datetime.date(2024, 5, 27), 'Memorial Day')
>>> for d, name in h.items():
>>> print(d, name)
2024-01-01 New Year's Day
2024-05-27 Memorial Day
2024-06-19 Juneteenth National Independence Day
2024-07-04 Independence Day
2024-09-02 Labor Day
2024-11-11 Veterans Day
2024-11-28 Thanksgiving
2024-12-25 Christmas Day
2024-01-15 Martin Luther King Jr. Day
2024-02-19 Washington's Birthday
2024-10-14 Columbus Day |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
a new function get_next_holiday is added to retrieve the date of the next known holiday.
Also the name of the holiday is returned.
It is possible to search forward and backward in time.
This should solve #1825
Documentation will be added once the basic changes are approved.
holidaysfunctionality in general)Checklist
make check, all checks and tests are green