Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Fix dependency solver flag not being parsed. #1189

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions .github/workflows/daily_common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,18 +85,17 @@ jobs:

- name: Install dependencies
run: |
nimble install -y --depsOnly
if [[ "${{ inputs.use_sat_solver }}" == "true" ]]; then
dependency_solver_flag="--solver:sat"
else
dependency_solver_flag="--solver:legacy"
fi

nimble install ${dependency_solver_flag} -y --depsOnly

- name: Run tests
run: |
nim --version
nimble --version

if [[ "${{ inputs.use_sat_solver }}" == "true" ]]; then
dependency_solver="sat"
else
dependency_solver="legacy"
fi

NIMFLAGS="${NIMFLAGS} --mm:${{ matrix.nim.memory_management }} --solver:${dependency_solver}"
nimble test
NIMFLAGS="${NIMFLAGS} --mm:${{ matrix.nim.memory_management }}" nimble test
1 change: 1 addition & 0 deletions .github/workflows/daily_sat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: Daily SAT
on:
schedule:
- cron: "30 6 * * *"
pull_request:
workflow_dispatch:

jobs:
Expand Down
Loading