Fin de la session 1 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesdlrsa
reviewed
Sep 2, 2021
| import { success } from '@libs/response'; | ||
|
|
||
| export const main: APIGatewayProxyHandler = async event => { | ||
| console.log(event); |
charlesdlrsa
reviewed
Sep 2, 2021
|
|
||
| export const main: APIGatewayProxyHandler = async (event) => { | ||
| /* | ||
| La fonction doit générer 1 virus si un id est passé en query param |
There was a problem hiding this comment.
de base les commentaires, c'est pas ouf, mieux vaut les retirer.
Si le code a besoin de commentaires, c'est qu'il n'est pas assez découpé ou que le nom des variables n'est pas assez clair :)
charlesdlrsa
reviewed
Sep 2, 2021
| La fonction doit générer 1 virus si un id est passé en query param | ||
| Sinon elle en génère 4 | ||
| */ | ||
| let viruses = [{}] |
There was a problem hiding this comment.
initialise le seulement avec une liste vide non ?
et type ton tableau, ex: let viruses: Virus[] = [] où Virus est un type {id: string}
charlesdlrsa
reviewed
Sep 2, 2021
|
|
||
| useAsync(async (id = 'TEST') => { |
There was a problem hiding this comment.
faudra qu'on reparle ensemble en live de tout ça :) j'ai besoin d'un peu de contexte
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.