Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] helm chart #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[ADD] helm chart #102

wants to merge 1 commit into from

Conversation

pushthat
Copy link

Hey,

This Helm chart facilitate the creation of a sonic statefullset on Kubernetes.

Regard,

@OGKevin
Copy link
Contributor

OGKevin commented Apr 6, 2019

I think this PR would be more appropriate in the official helm repo maybe ? 🤔

@pushthat
Copy link
Author

pushthat commented Apr 8, 2019

Not all the requirements are met for this chart to be accepted on the helm/charts repo, like all the parameters of the configmap not being configurable from the values.yaml
I made this chart as a first working iteration

@sergeyshaykhullin
Copy link

@pushthat @valeriansaliou
Hello, any updates on this?
Thanks!

volumeMounts:
{{- if .Values.persistence.enabled }}
- name: data
mountPath: /var/lib/sonic/store/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be?

Suggested change
mountPath: /var/lib/sonic/store/
mountPath: /usr/src/sonic/data

because in config is path = "./data/store/kv/" and workdir is /usr/src/sonic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants