Skip to content

Commit

Permalink
get rid of letters
Browse files Browse the repository at this point in the history
Signed-off-by: Chloe Yip <[email protected]>
  • Loading branch information
cyip10 committed Oct 3, 2024
1 parent 7217bef commit 911ff05
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions RELEASING.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,6 @@ The CD workflow can be triggered in several ways.
1. **By pushing a Version Tag**: Trigger the CD workflow by pushing a version tag in the format "v*.*." or "v.*.*-rc".
For example, v1.0.0-rc1. When triggered by a push event with a version tag, all package manager CD workflows (e.g., pypi-cd.yml, npm-cd.yml, java-cd.yml) will be initiated.
The version will be extracted from the tag.

a.
```
[13:39:23] ubuntu $ git remote -vv
origin https://github.com/your-repo/valkey-glide (fetch)
Expand All @@ -127,10 +125,8 @@ The version will be extracted from the tag.
This is done on a specific CD workflow by passing the required version as an input parameter in the format "*.*.*" or "*.*.*-rc*".
This method will not trigger deployments for other package managers and will not create a tag in the repository.

a. <br>
![pypi CD](docs/images/releasing/pypi-CD.png)


3. **Pull Requests:** Pull requests will trigger the CD workflows as "dry runs" without actually publishing to the package managers.
This ensures that changes do not break the CD logic. Note that PRs affecting the CD workflows (e.g., introducing changes in the CD paths) can only be opened from branches on the
valkey-io/valkey-glide main repo (rather than from forks) since running the CD, even without publishing, requires access to the repository's secrets.
Expand Down

0 comments on commit 911ff05

Please sign in to comment.