Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Revises DEVELOPER.md file. (#403) #1875

Merged

Conversation

tetrachromium
Copy link
Contributor

Revises the DEVELOPER.md file to improve clarity and reduce the potential for confusion. The order of some sections has been changed to help ensure the correct dependencies have been installed before attempting to install the protobuf compiler. A forward reference to the Troubleshooting section has been added to assist readers in finding solutions to some common installation problems.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Yury-Fridlyand Yury-Fridlyand added java issues and fixes related to the java client docs Documentation labels Jul 8, 2024
@tetrachromium tetrachromium force-pushed the java/integ_developer_doc_revisions branch from 2047930 to 805d3fe Compare July 9, 2024 18:01
@tetrachromium tetrachromium requested a review from a team as a code owner July 9, 2024 18:01
@jonathanl-bq
Copy link
Collaborator

DCO failed. You need to make your commits with git commit -s to fix.

* Revises `DEVELOPER.md` file.

* Updates `cd` command to reduce potential for confusion

* Adds clarification

* Reverts heading format changes per code review comment

Signed-off-by: Roger Neate <[email protected]>
@tetrachromium tetrachromium force-pushed the java/integ_developer_doc_revisions branch from 805d3fe to 04ec816 Compare July 9, 2024 21:04
@barshaul barshaul merged commit 32739e7 into valkey-io:main Jul 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation java issues and fixes related to the java client
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants