Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allign 'GLIDE for Valkey' section of README.MD for node, csharp and java #1899

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

ikolomi
Copy link
Collaborator

@ikolomi ikolomi commented Jul 9, 2024

Although node and csharp are not included in the upcoming GA , their readmes should have the common 'GLIDE for Valkey' section. Additionally, fix java readme

@ikolomi ikolomi requested a review from shohamazon July 9, 2024 13:05
@ikolomi ikolomi requested a review from a team as a code owner July 9, 2024 13:05
csharp/README.md Outdated Show resolved Hide resolved
node/README.md Outdated
@@ -1,7 +1,6 @@
# GLIDE for Redis
# GLIDE for Valkey
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# GLIDE for Valkey
# Valkey GLIDE

Copy link
Collaborator

@shohamazon shohamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplication of #1888

@ikolomi ikolomi changed the title Allign 'GLIDE for Valkey' section of README.MD for node and csharp Allign 'GLIDE for Valkey' section of README.MD for node, csharp and java Jul 9, 2024
@ikolomi ikolomi merged commit e0dbe4b into main Jul 9, 2024
20 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the fix_node_csharp_readme branch July 16, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants