-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: Update README for local maven installation instructions #1905
Java: Update README for local maven installation instructions #1905
Conversation
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Since the artifacts aren't available in Maven Central yet, this is a possible temporary workaround, but I don't think this should go into a README as this is not a typical or recommended way to consume the artifacts. |
Yes. Agreed. We will want to remove this (or move to the Developer.md for how to use the ExampleApp) as soon as the Maven Central artefacts are up and available. |
Signed-off-by: Andrew Carbonetto <[email protected]>
I'm having an issue getting classifier resolution to work with this approach. Trying to see if I can make it work with |
You can use (for classifier
and for dependency:
|
I'm trying that (but with
But actually it looks like the artifacts are now on Maven Central so hopefully this workaround isn't needed anymore. I'll try to use those artifacts now. |
That error was because I was specifying the
But that sets the This works:
And it looks like I can just do:
But this might only be working for |
Here is the project that works for me (on It'll be interesting to see if the classifier doesn't work for others on different OS / Architectures. |
I guess that gradle resolves |
@@ -47,6 +47,25 @@ java -version | |||
|
|||
_Note: Publishing to Maven is pending; the examples below will be available once artifacts are published. You can also download artifacts from the [GitHub release](https://github.com/valkey-io/valkey-glide/releases/tag/v1.0.0) and add the jar file to the project._ | |||
|
|||
**Temporary Workaround while Artifacts pending to Maven Central** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this PR? GLIDE is already published on maven central.
I am successfully using https://github.com/sullis/valkey-playground/blob/main/pom.xml I am using |
No description provided.