Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go:Implement GetEx command #2329

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Conversation

janhavigupta007
Copy link
Collaborator

Implementing the GETEX command with and without options in GO client.

Signed-off-by: Janhavi Gupta <[email protected]>
@janhavigupta007 janhavigupta007 requested a review from a team as a code owner September 19, 2024 06:17
@janhavigupta007 janhavigupta007 self-assigned this Sep 19, 2024
@janhavigupta007 janhavigupta007 added the go golang wrapper label Sep 19, 2024
go/api/base_client.go Outdated Show resolved Hide resolved
go/api/command_options.go Outdated Show resolved Hide resolved
go/api/command_options.go Show resolved Hide resolved
go/api/commands.go Outdated Show resolved Hide resolved
Signed-off-by: Janhavi Gupta <[email protected]>
Copy link
Contributor

@eifrah-aws eifrah-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to wait with this PR until this one #2310 is merged?

@janhavigupta007
Copy link
Collaborator Author

Do we want to wait with this PR until this one #2310 is merged?

@eifrah-aws I am just waiting for an approving review in order to merge this PR. We don't need to block existing PRs on #2310 but while creating any further PRs we should consider the changes in #2310.

@janhavigupta007 janhavigupta007 merged commit 4b53749 into valkey-io:main Oct 1, 2024
13 checks passed
umit pushed a commit to umit/valkey-glide that referenced this pull request Oct 1, 2024
* Go:Implement GetEx command

Signed-off-by: Janhavi Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go golang wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants