-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all commands to proto #2389
base: main
Are you sure you want to change the base?
Add all commands to proto #2389
Conversation
@@ -21,7 +21,7 @@ def test_encode_decode_delimited(self): | |||
b_arr = bytearray() | |||
ProtobufCodec.encode_delimited(b_arr, request) | |||
msg_len_varint = int(b_arr[0]) | |||
assert msg_len_varint == 18 | |||
assert msg_len_varint == 19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small question:
What is the context around this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good question actually. Get/set commands used in this test got bigger numbers and now require more bytes to encode that.
Watch = 1605, | ||
|
||
//// JSON commands | ||
JsonArrAppend = 2001, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should split this PR into two:
- clean up all the existing commands
- add the JSON and VSS commands
|
||
//// JSON commands | ||
|
||
JsonArrAppend = 2001; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should split this PR into two:
- clean up all the existing commands
- add the JSON and VSS commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you mean in cleanup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refactor? move the enums? Cleanup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copy-pasted Very Big Enum into multiple places and fixed two broken refs (they were named incorrectly).
my honest question is just why 😐 |
We won't have merge conflicts in every PR if we add this now. |
No description provided.