Fix logger initialization on readonly filesystems #2391
Merged
+82
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the initiative! Appreciate that! I didn't get deeply into it yet (holidays), but at first glance, it seems good, i thought also to look for a lazy appender solution. As long as it's not urgent to you guys I'll review it on Sunday. Let me know if it is. If you want in the meantime to add the implementation of error handling in write-only systems you are welcome to add it to the PR. For passing CI you need to sign your commits. |
eifrah-aws
requested changes
Oct 6, 2024
vnuka-n
force-pushed
the
fix-logger-initalization-on-readonly-filesystems
branch
from
9ffdf46
to
3b61d8a
Compare
Calling RollingFileAppender::new tries to create the directory for the log files even though logging is turned off by Logger.init('off', null). This change simply postpones the initialization of RollingFileAppender until it is actually needed. This way if we do eg. Logger.init("info", null) it works as expected and does not throw an error on readonly filesystems.
Fixes valkey-io#2387
Signed-off-by: Ville Nukarinen <[email protected]>
vnuka-n
force-pushed
the
fix-logger-initalization-on-readonly-filesystems
branch
from
3b61d8a
to
5755de3
Compare
|
Signed the commit and amended all the requested changes. |
avifenesh
approved these changes
Oct 7, 2024
ready on my side, so go ahead 😄 |
eifrah-aws
approved these changes
Oct 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling RollingFileAppender::new tries to create the directory for the log files even though logging is turned off by Logger.init('off', null). This change simply postpones the initialization of RollingFileAppender until it is actually needed. This way if we do eg. Logger.init("info", null) it works as expected and does not throw an error on readonly filesystems.
Fixes #2387