Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor update for node build #2393

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Yury-Fridlyand
Copy link
Collaborator

Allows to build node client on a fresh repo clone without addition voodoo.

npm install is needed to avoid such errors

> compile-protobuf-files
> cd src && pbjs -t static-module -o ProtobufMessage.js ../../glide-core/src/protobuf/*.proto && pbts -o ProtobufMessage.d.ts ProtobufMessage.js

sh: 1: pbjs: not found

(missing protobufjs-cli)

@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner October 5, 2024 00:56
Copy link
Collaborator

@avifenesh avifenesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!
But if we go for it already, I'd say we should do it as well for:
glide-logs
glide-rs.os-arch-libc-node
d.ts and js files in rust-client
proto files in src

And maybe in a separate that can be joined, clean all node stuff, lock.json, node_modules etc.

@jonathanl-bq
Copy link
Collaborator

Maybe create a new issue to track the rest of the work that @avifenesh mentioned. I'm in favour of keeping PRs small, so I think this one is fine as is and the rest can be done in other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants