Go: Implement Bitfield and Bitfield ReadOnly commands #2999
+500
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niharika Bhavaraju <[email protected]>
| return &BitFieldOptions{} | ||
| } | ||
|
|
||
| // AddGet adds a GET subcommand |
There was a problem hiding this comment.
Don't we need docs for parameters?
| return opts | ||
| } | ||
|
|
||
| func (opts *BitFieldOptions) ToArgs() []string { |
There was a problem hiding this comment.
Probably return a tuple to align with others, even when error is always nil for now
Suggested change
| func (opts *BitFieldOptions) ToArgs() []string { | |
| func (opts *BitFieldOptions) ToArgs() ([]string, error) { |
| // fmt.Println(result) // Output: [7 13] | ||
| // | ||
| // [valkey.io]: https://valkey.io/commands/bitfield/ | ||
| func (client *baseClient) BitField(key string, options *options.BitFieldOptions) ([]int64, error) { |
There was a problem hiding this comment.
With *options (pointer) a user can pass nil, but API is not designed to support this I think.
There was a problem hiding this comment.
Alternative variant is
Suggested change
| func (client *baseClient) BitField(key string, options *options.BitFieldOptions) ([]int64, error) { | |
| func (client *baseClient) BitField(key string, subcommands []BitFieldSubcommand) ([]int64, error) { |
where
type BitFieldSubcommand interface {
ToArgs() ([]string, error)
}And you can share implementations for BitField and BitFieldRO
I did similar thing for ZRange
| @@ -321,6 +321,29 @@ func handleIntArrayResponse(response *C.struct_CommandResponse) ([]int64, error) | |||
| return slice, nil | |||
| } | |||
|
|
|||
| func handleIntOrNilArrayResponse(response *C.struct_CommandResponse) ([]int64, error) { | |||
There was a problem hiding this comment.
We already have https://github.com/niharikabhavaraju/valkey-glide/blob/34bd8722ad34a0ba7b37407a5752c8851feee9ce/go/api/response_handlers.go#L305
Or you want nillable ints there?
Suggested change
| func handleIntOrNilArrayResponse(response *C.struct_CommandResponse) ([]int64, error) { | |
| func handleIntOrNilArrayResponse(response *C.struct_CommandResponse) ([]Result[int64], error) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go: Implement Bitfield and Bitfield ReadOnly commands