Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#123: Distinguishing nodeRemoved and nodeMoved events #254

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pavsergus
Copy link

There are some use cases where nodeRemoved event firing is undesirable and confusing.

@pavsergus
Copy link
Author

Proposed as a fix for #123

@codecov
Copy link

codecov bot commented Apr 10, 2018

Codecov Report

Merging #254 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #254   +/-   ##
========================================
  Coverage    92.13%   92.13%           
========================================
  Files           25       25           
  Lines         1030     1030           
  Branches       146      146           
========================================
  Hits           949      949           
  Misses          53       53           
  Partials        28       28
Impacted Files Coverage Δ
src/tree-internal.component.ts 82.88% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6414d5...5e8f64c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants