Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add feature gate for zerion transaction feed #6181

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kathaypacific
Copy link
Collaborator

Description

As the title.

While updating the TabHome tests, I noticed every test was throwing an act warning (below) so this PR also updates the tests to remove the errors.

Warning: An update to TransactionFeed inside a test was not wrapped in act(...).
    
    When testing, code that causes React state updates should be wrapped into act(...):
    
    act(() => {
      /* fire events that update state */
    });
    /* assert on the output */

Test plan

Tested via unit tests and manually.

Related issues

n/a

Backwards compatibility

Y

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (16e2f2e) to head (f015f40).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6181      +/-   ##
==========================================
- Coverage   88.87%   88.86%   -0.02%     
==========================================
  Files         730      730              
  Lines       31037    31043       +6     
  Branches     5696     5697       +1     
==========================================
+ Hits        27584    27586       +2     
+ Misses       3411     3261     -150     
- Partials       42      196     +154     
Files with missing lines Coverage Δ
src/home/TabHome.tsx 97.36% <100.00%> (-1.23%) ⬇️
src/statsig/types.ts 100.00% <100.00%> (ø)

... and 67 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16e2f2e...f015f40. Read the comment docs.

Copy link
Contributor

@sviderock sviderock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants