Support for alternate cookie domain #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, sorry for the very late reply. I've merged the alternate domain stuff. The other commits contain a lot of format changes (removed lines, other indents aso...) so it is hard to guess what really changed... |
|
Ugh, sorry about that, and my bad too for doing a pull request from my master branch. The 2nd key change is that the request headers also include:
Otherwise Joomla will run out of outgoing HTTP connections. |
valpo
pushed a commit
that referenced
this pull request
Jun 21, 2018
Joomla 3 Changes and Group map supports multiple Joomla group ids per crowd group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi There,
I must say that your plugin has been handy. Here is a commit which includes support for an alternate cookie domain.
Eg: if the webserver is operating under a different domain to crowd.