Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query eventlog offset add start offset #606

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

xdlbdy
Copy link
Contributor

@xdlbdy xdlbdy commented Jul 6, 2023

What problem does this PR solve?

Issue Number: close #605

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@xdlbdy xdlbdy requested a review from ifplusor as a code owner July 6, 2023 06:31
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #606 (7a8b6bd) into main (ee76217) will decrease coverage by 2.95%.
The diff coverage is 48.20%.

❗ Current head 7a8b6bd differs from pull request most recent head d5fb0ec. Consider uploading reports for the commit d5fb0ec to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
- Coverage   57.07%   54.12%   -2.95%     
==========================================
  Files         190      224      +34     
  Lines       15191    18051    +2860     
==========================================
+ Hits         8670     9770    +1100     
- Misses       5884     7494    +1610     
- Partials      637      787     +150     
Impacted Files Coverage Δ
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
internal/controller/trigger/worker/manager.go 85.76% <ø> (+0.83%) ⬆️
internal/controller/trigger/worker/policy.go 100.00% <ø> (ø)
internal/controller/trigger/worker/scheduler.go 71.01% <ø> (+1.01%) ⬆️
internal/controller/trigger/worker/worker.go 78.45% <ø> (-1.55%) ⬇️
internal/gateway/config.go 60.60% <ø> (-0.51%) ⬇️
internal/gateway/gateway.go 57.64% <ø> (-10.03%) ⬇️
internal/gateway/proxy/auth.go 0.00% <ø> (ø)
internal/gateway/proxy/deadletter.go 0.00% <ø> (ø)
internal/gateway/proxy/direct.go 15.84% <ø> (-57.50%) ⬇️
... and 69 more

... and 80 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 889c977...d5fb0ec. Read the comment docs.

client/pkg/eventlog/eventlog_impl.go Outdated Show resolved Hide resolved
@xdlbdy xdlbdy merged commit 8bbfce9 into vanus-labs:main Jul 6, 2023
@xdlbdy xdlbdy deleted the fix_offset branch July 6, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client get offset by time lost start
2 participants