Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: template does not follow RFC3339 time format #639

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

ifplusor
Copy link
Collaborator

What problem does this PR solve?

template does not follow the RFC3339 time format.

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #639 (f3da796) into main (ee76217) will decrease coverage by 5.84%.
Report is 101 commits behind head on main.
The diff coverage is 3.63%.

❗ Current head f3da796 differs from pull request most recent head 16429d8. Consider uploading reports for the commit 16429d8 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
- Coverage   57.07%   51.24%   -5.84%     
==========================================
  Files         190      259      +69     
  Lines       15191    19514    +4323     
==========================================
+ Hits         8670     9999    +1329     
- Misses       5884     8698    +2814     
- Partials      637      817     +180     
Flag Coverage Δ
unittests 51.24% <3.63%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/errors/app.go 30.90% <ø> (ø)
lib/bytes/escape.go 54.46% <ø> (ø)
lib/bytes/io.go 0.00% <ø> (ø)
lib/bytes/parse.go 7.14% <ø> (ø)
lib/bytes/unsafe.go 100.00% <ø> (ø)
lib/bytes/utf8.go 11.11% <ø> (ø)
lib/json/path/parse.go 49.41% <ø> (ø)
lib/json/path/path.go 0.00% <ø> (ø)
lib/json/path/segment.go 0.00% <ø> (ø)
lib/json/path/selector.go 0.00% <ø> (ø)
... and 30 more

... and 393 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c31d91...16429d8. Read the comment docs.

Signed-off-by: James Yean <[email protected]>
@ifplusor ifplusor requested a review from xdlbdy October 17, 2023 08:12
@ifplusor ifplusor merged commit a3dd7d0 into vanus-labs:main Oct 17, 2023
2 of 3 checks passed
@ifplusor ifplusor deleted the fix-time-format branch October 17, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants