Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use go.uber.org/mock instead of github.com/golang/mock #645

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

ifplusor
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 477 lines in your changes are missing coverage. Please review.

Comparison is base (ee76217) 57.07% compared to head (1d0bad2) 51.31%.
Report is 107 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #645      +/-   ##
==========================================
- Coverage   57.07%   51.31%   -5.76%     
==========================================
  Files         190      260      +70     
  Lines       15191    19566    +4375     
==========================================
+ Hits         8670    10041    +1371     
- Misses       5884     8706    +2822     
- Partials      637      819     +182     
Flag Coverage Δ
unittests 51.31% <3.63%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/errors/app.go 30.90% <ø> (ø)
lib/bytes/clone_go119.go 0.00% <ø> (ø)
lib/bytes/escape.go 54.46% <ø> (ø)
lib/bytes/io.go 0.00% <ø> (ø)
lib/bytes/parse.go 7.14% <ø> (ø)
lib/bytes/unsafe.go 100.00% <ø> (ø)
lib/bytes/utf8.go 11.11% <ø> (ø)
lib/json/path/parse.go 49.41% <ø> (ø)
lib/json/path/path.go 0.00% <ø> (ø)
lib/json/path/segment.go 0.00% <ø> (ø)
... and 31 more

... and 393 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d9a94...1d0bad2. Read the comment docs.

@ifplusor ifplusor merged commit 1334a7b into vanus-labs:main Dec 21, 2023
4 of 6 checks passed
@ifplusor ifplusor deleted the gomock branch December 21, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants