Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify signing and notifications APIs #17

Merged
merged 7 commits into from
Dec 1, 2024
Merged

Simplify signing and notifications APIs #17

merged 7 commits into from
Dec 1, 2024

Conversation

fpseverino
Copy link
Member

  • Refactor and simplify pass/order signing and building
    • Certs and keys are now stored in their PEM string format, not as files
  • Simplify push notifications APIs
  • Add tests for localized pass/order images

0xTim
0xTim approved these changes Dec 1, 2024
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, query around layout and a shared module but nothing blocking

Sources/Passes/PassesError.swift Outdated Show resolved Hide resolved
@fpseverino fpseverino merged commit 61371c3 into vapor-community:main Dec 1, 2024
7 of 11 checks passed
@fpseverino fpseverino deleted the update branch December 1, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim approved these changes

@gwynne gwynne Awaiting requested review from gwynne

@MahdiBM MahdiBM Awaiting requested review from MahdiBM

@ptoffy ptoffy Awaiting requested review from ptoffy

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpseverino @0xTim