This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
add support for enabling HTTP pipelining #320
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 12, 2018
t089
reviewed
Dec 13, 2018
| @@ -126,6 +128,9 @@ private final class HTTPServerHandler<R>: ChannelInboundHandler where R: HTTPSer | |||
|
|
|||
| /// Optional server header. | |||
| private let serverHeader: String? | |||
|
|
|||
| /// If true, we are waiting for a response to be sent. | |||
| var awaitingReponse: Bool | |||
There was a problem hiding this comment.
Suggested change
| var awaitingReponse: Bool | |
| private(set) var awaitingReponse: Bool |
?
|
Super, looks good to me. I've just opened #321 to add a test case for pipelining. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supportPipeliningtoHTTPServer.start.HTTPServerHandler.vapor.codessince Amazon's TLS seems to be unreliable.