Fix usage of the Metrics Timer. #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptoffy
reviewed
Sep 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
==========================================
+ Coverage 84.48% 84.76% +0.28%
==========================================
Files 22 22
Lines 709 709
==========================================
+ Hits 599 601 +2
+ Misses 110 108 -2
|
The matching is on the dimensions, so that wouldn't fix the issue. Apart from the memory issue that, I've just found out, affects Prometheus 1 only I think, if you use the job id in the dimensions, you're not aggregating anything. You're getting a separate histogram made out of one data point for each run of a job. Like this: |
|
I think this is the kind of output that's useful? |
ptoffy
approved these changes
Sep 12, 2024
|
@0xTim not sure if you want to give this a once over too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 1.16.1
When using the
Timeraggregate the measurements by status and job name rather than by status and job id.Job id is unique to each job run and therefore in the current implementation a new summary is created for each job run which doesn't collect useful metrics data and causes excessive memory usage.