A new home #112
Merged
A new home #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xTim
reviewed
Jun 20, 2024
MahdiBM
reviewed
Jul 13, 2024
There was a problem hiding this comment.
Nice deployment preview we have there.
Looks good.
One inaccuracy is that @gwynne pruned a lot of the Discord members so users inactive past 1 month or something (at that time) got kicked and we now have only 4K members.
Though the "online members" number is still the same and the ratio should be even higher ... so maybe we could focus on that "online members" number.
0xTim
requested changes
Jul 15, 2024
There was a problem hiding this comment.
Some things I've noticed:
- Leaf link points to 4.0 we should fix that
- The compiler error has a
*- I think it should be' - The showcase section links aren't implemented. See full list should point to the showcase page for example and the scroll buttons I'm assuming don't work as we don't have any more to show? (They work on mobile)
- Become a supporter link does nothing
- The sponsors section on mobile is cut off, we should show the scroll buttons below a certain size or wrap them in a flex box so they're on different lines (can't remember what the design had)
Looking great though!
0xTim
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.