-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Failing Tests, Address Client Connection Issue #155
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
=======================================
Coverage 82.85% 82.85%
=======================================
Files 6 6
Lines 659 659
=======================================
Hits 546 546
Misses 113 113
|
The semantics of |
We really shouldn't be touching BoringSSL anymore |
Yeah, but that's out of scope for this PR. |
Ill check these tests and update. |
… reliable and consistant across platforms.
…st what is consistently behaved across platforms.
Im beginning to think there is no way to resolve this issue with this test. The behavior is not consistent enough across swift versions and platforms. The utility of the test is unknown to me also. I don't know how to even do it (much less elegantly), to handle URL initialization across versions and platforms. |
Updated from swift-tools-version:5.7 to 5.9.
This fixes an issue where clients would get a bad Sec-WebSocket-Accept value from vapor.
Fixed bad url tests on WebSocket, Async and regular.
There is an issue for covering all bad urls that the WebSocket might reject as URL seems to init fragments such as bare escape sequences. I'm not sure yet how that could be covered better, or how important it is.