vdef: Add TFOREACH() macro for txt #4194
Conversation
include/vdef.h
Outdated
| @@ -266,6 +266,8 @@ typedef struct { | |||
| #define Tstr(s) (/*lint -e(446)*/ (txt){(s), (s) + strlen(s)}) | |||
| #define Tstrcmp(t, s) (strncmp((t).b, (s), Tlen(t))) | |||
|
|
|||
| #define TFOREACH(c, t) for ((c) = (t).b; (c) < (t).e; (c)++) | |||
There was a problem hiding this comment.
Nice find.
Could we instead go for #define Tforeach(c, t) ? or #define TXT_FOREACH(c, t) ?
It was not obvious to me what the macro was meant to iterate over.
There was a problem hiding this comment.
T'was not obvious to me either so I went with T like in other txt-related macros and FOREACH like in other iterator macros.
TXT_FOREACH() was my alternative.
The pun was of course intended.
There was a problem hiding this comment.
My useless contribution on bikeshed colors: TXT_FOREACH_CHAR
Please not TFOREACH, for consistency I'd otherwise propose Tforeach or Titer
There was a problem hiding this comment.
I suppose Traverse() was the better name, too late...
There was a problem hiding this comment.
Never too late to rename for the better ;)
|
I'm OK with any sensible name which is "in-family", ie T[a-z]* |
Courtesy of Coccinelle.
|
I was waiting for CI to complete after making the change. |
Random idea of the day.